switched to lists instead loops

roles/install-packages/tasks/main.yml

@@ -1,55 +1,22 @@
 ---
 # tasks file for install-packages
 - block: # red hat based distros
-  - yum: name={{item}} state=latest update_cache=True
+  - yum: 
-    with_items:
+      name: ['iptables-services', 'iperf3', 'git', 'zsh', 'vim', 'wget', 'epel-release', 'bmon', 'curl', 'tcpdump', 'nmap', 'mc', 'nano', 'iptraf-ng']
-    - iptables-services
+      state: latest 
-    - iperf3
+      update_cache: True
-    - git
-    - zsh
-    - vim
-    - wget
-    - epel-release
-    - bmon
-    - curl
-    - tcpdump
-    - nmap
-    - mc
-    - nano
-    - iptraf-ng
   when: ansible_os_family == "RedHat"
 
 - block: # debian based distros
-  - apt: name={{item}} state=latest update_cache=True
+  - apt: 
-    with_items:
+      name: ['iperf3', 'git', 'zsh', 'vim', 'wget', 'bmon', 'curl', 'tcpdump', 'nmap', 'nano', 'mc', 'iptraf-ng']
-    - iperf3
+      state: latest
-    - git
+      update_cache: True
-    - zsh
-    - vim
-    - wget
-    - bmon
-    - curl
-    - tcpdump
-    - nmap
-    - nano
-    - mc
-    - iptraf-ng
   when: ansible_os_family == "Debian"
 
 - block: # alpine
-  - apk: name={{item}} state=latest update_cache=True
+  - apk: 
-    with_items:
+      name: ['git', 'zsh', 'zsh-vcs', 'vim', 'wget', 'curl', 'tcpdump', 'nmap', 'bmon', 'shadow', 'nano', 'mc', 'iptraf-ng']
-    - git
+      state: latest
-    - zsh
+      update_cache: True
-    - zsh-vcs
-    - vim
-    - wget
-    - curl
-    - tcpdump
-    - nmap
-    - bmon
-    - shadow
-    - nano
-    - mc
-    - iptraf-ng
   when: ansible_os_family == "Alpine"

roles/install-zsh-and-vim/tasks/main.yml

@@ -1,40 +1,23 @@
 ---
 - block: #red hat based distros
   - yum: 
-      name: '{{ item }}' 
+      name: ['git', 'zsh', 'vim', 'wget']
       state: latest 
       update_cache: true
-    with_items:
-      - git
-      - zsh
-      - vim
-      - wget
   when: ansible_os_family == "RedHat" and install_deps == true and update_only == false
 
 - block: #debian based distros
   - apt: 
-      name: '{{ item }}' 
+      name: ['git', 'zsh', 'vim', 'wget']
       state: latest 
       update_cache: true
-    with_items:
-      - git
-      - zsh
-      - vim
-      - wget
   when: ansible_os_family == "Debian" and install_deps == true and update_only == false
 
 - block: #alpine
   - apk:
-      name: '{{ item }}' 
+      name: ['git', 'zsh', 'vim', 'wget', 'zsh-vcs', 'shadow']
       state: latest 
       update_cache: true
-    with_items:
-      - git
-      - zsh
-      - vim
-      - wget
-      - zsh-vcs
-      - shadow
   when: ansible_os_family == "Alpine" and install_deps == true and update_only == false
 
 - name: change default shell